Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

soroban-rpc: Use External Soroban Crates #3

Closed
wants to merge 7 commits into from
Closed

soroban-rpc: Use External Soroban Crates #3

wants to merge 7 commits into from

Conversation

stellarsaur
Copy link
Contributor

@stellarsaur stellarsaur commented Jan 18, 2024 •
edited
Loading

What

Rather than building crates locally, this PR fetches published versions from crates.io instead.

Why

The soroban-tools repository should be responsible for building & publishing these crates.

@stellarsaur stellarsaur marked this pull request as ready for review January 18, 2024 02:27
@stellarsaur stellarsaur self-assigned this Jan 18, 2024
@stellarsaur stellarsaur added the enhancement New feature or request label Jan 18, 2024
@stellarsaur stellarsaur requested review from leighmcculloch and a team January 18, 2024 16:59
@sreuland
Copy link
Contributor

it's not in this change set, but the refs to rpc and cli repos in e2e.yml needs to now be udpated to ref this repo and wherever cli resides now(still soroban-tools?)

https://github.com/stellar/soroban-rpc/blob/rpc-prune/.github/workflows/e2e.yml#L93-L94

otherwise based on current e2e.yml config, it's passing based off code in soroban-tools not this repo

@stellarsaur
Copy link
Contributor Author

it's not in this change set, but the refs to rpc and cli repos in e2e.yml needs to now be udpated to ref this repo and wherever cli resides now(still soroban-tools?)

https://github.com/stellar/soroban-rpc/blob/rpc-prune/.github/workflows/e2e.yml#L93-L94

otherwise based on current e2e.yml config, it's passing based off code in soroban-tools not this repo

Thanks for the reminder!

Please reference this PR moving forward. Closing this one as it's stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leighmcculloch leighmcculloch Awaiting requested review from leighmcculloch

Assignees

@stellarsaur stellarsaur

Labels
enhancement New feature or request
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stellarsaur @sreuland